Conversation
|
Some changes occurred in the Android module cc @maurer |
|
These look good to me, but there seem to be a few more cases. Would you mind getting those as well? https://github.com/search?q=repo%3Arust-lang%2Flibc%20%2F%3A.*fn%5C(%2F&type=code for a rough search, e.g. the aix module, solaris, espidf, and a few others. We can't backport this since it is breaking unfortunately, but it will be great to have for 1.0: @rustbot label +stable-declined |
|
@rustbot author for the request above |
|
Reminder, once the PR becomes ready for a review, use |
|
@highjeans gentle ping, would you be able to take a look at the above suggestion? |
|
@tgross35 Sorry for the late response, I was busy with a large assignment for university. I am outside today, but when I get home I will take a look and update the PR. |
|
@highjeans another gentle ping on this one :) |
|
☔ The latest upstream changes (possibly #5011) made this pull request unmergeable. Please resolve the merge conflicts. |
Description
This PR changes the callback function type to be unsafe rather than safe in (i believe) all functions that need a callback function, as per the discussion in #2198.
Closes #2198
Sources
As no APIs were changes (other than making the callback type unsafe), and safe vs unsafe functions are not documented in the linux documentation/header files, there are no sources.
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI