freebsd15: Add ki_uerrmsg to struct kinfo_proc#4553
Conversation
|
@asomers given this does technically break the struct definition, do you want this on stable? I think if this is done, the struct should be marked The change itself LGTM |
|
This change only affects FreeBSD 15. That release is still under development, and therefore no backwards-compatibility concerns apply. So yes I think we should merge it to libc-0.2. |
|
Thanks for confirming, that's perfect. I think we should still add |
tgross35
left a comment
There was a problem hiding this comment.
could you just make the struct #[non_exhaustive]? We're starting to do this for everything new, may as well do it with the change here as well
228246f to
b8d9379
Compare
struct kinfo_proc may be extended again in the future. Add #[non_exhaustive] to let the compiler and other tooling know.
b8d9379 to
65331f2
Compare
commit added. |
struct kinfo_proc may be extended again in the future. Add #[non_exhaustive] to let the compiler and other tooling know. (backport <rust-lang#4553>) (cherry picked from commit 9ee2d2a)
struct kinfo_proc may be extended again in the future. Add #[non_exhaustive] to let the compiler and other tooling know. (backport <rust-lang#4553>) (cherry picked from commit 9ee2d2a)
struct kinfo_proc may be extended again in the future. Add #[non_exhaustive] to let the compiler and other tooling know. (backport <rust-lang#4553>) (cherry picked from commit 9ee2d2a)
Description
During the development of FreeBSD 15, a field was added to
kinfo_proc. With this PR and #4552, thelibc-testsuite passes on FreeBSD 15 on ppc64.Sources
Upstream commit: freebsd/freebsd-src@7212b37
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI