Export UDP socket option consts on Android#4619
Conversation
|
Some changes occurred in the Android module cc @maurer |
|
We only need the UDP_SEGMENT and UDP_GRO for our use-case. |
|
The two you've added are fine. If you want to add more, please restrict yourself to those in https://cs.android.com/android/platform/superproject/main/+/main:bionic/libc/kernel/uapi/linux/udp.h - mostly that means no (This is |
2c9abc2 to
8a94eb1
Compare
|
@maurer Thanks for clarifying, I was not aware of the distinction with bionic. I've updated the PR to include all UDP socket options. I've left out the ENCAP-stuff though since I am unfamiliar with them. I've also added bionic to the list of sources. |
(backport <rust-lang#4619>) (cherry picked from commit a43bdc3)
(backport <rust-lang#4619>) (cherry picked from commit a43bdc3)
Description
Export constants for all UDP-specific socket options on Android.
These are already exposed on Linux proper here and here.
Sources
linux/include/uapi/linux/udp.h
bionic/libc/kernel/uapi/linux/udp.h
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated