Skip to content

Update SO_* constants for Fuchsia #4937

Merged
tgross35 merged 1 commit intorust-lang:mainfrom
SergeyUlanov:main
Jan 24, 2026
Merged

Update SO_* constants for Fuchsia #4937
tgross35 merged 1 commit intorust-lang:mainfrom
SergeyUlanov:main

Conversation

@SergeyUlanov
Copy link
Contributor

Description

Added SO_COOKIE, SO_TIMESTAMPNS and SO_FUCHSIA_MARK.

Sources

https://cs.opensource.google/fuchsia/fuchsia/+/main:zircon/third_party/ulib/musl/include/sys/socket.h;drc=dccb7cd7068c6f4ddccb7cec20a5005d088e6403;l=254
https://cs.opensource.google/fuchsia/fuchsia/+/main:sdk/lib/zxio/include/lib/zxio/bsdsocket.h;drc=5d501ce908b866891bf221abe13d7cfa14bf992d;l=89

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    cargo test doesn't run tests on Fuchsia target currently

@tgross35
Copy link
Contributor

This looks fine to me as long as the target maintainers say these are useful, @erickt @Nashenas88 could you review?

Please squash as well.

Copy link
Contributor

@erickt erickt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches our config in fuchsia, thanks!

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erickt for reviewing!

Just kicking back for the squash

@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Added SO_COOKIE, SO_TIMESTAMPNS and SO_FUCHSIA_MARK.
@SergeyUlanov
Copy link
Contributor Author

squashed the changes.
@rustbot ready

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tgross35 tgross35 enabled auto-merge January 24, 2026 01:08
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jan 24, 2026
@tgross35 tgross35 added this pull request to the merge queue Jan 24, 2026
Merged via the queue into rust-lang:main with commit a940a7d Jan 24, 2026
50 of 51 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Feb 9, 2026
Added SO_COOKIE, SO_TIMESTAMPNS and SO_FUCHSIA_MARK.

(backport <rust-lang#4937>)
(cherry picked from commit a940a7d)
@tgross35 tgross35 mentioned this pull request Feb 9, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 9, 2026
Added SO_COOKIE, SO_TIMESTAMPNS and SO_FUCHSIA_MARK.

(backport <#4937>)
(cherry picked from commit a940a7d)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants