Skip to content

fix(redox): incorrect values for PTHREAD_MUTEX_{NORMAL, RECURSIVE}#4943

Merged
JohnTitor merged 1 commit intorust-lang:mainfrom
aero-os:main
Jan 27, 2026
Merged

fix(redox): incorrect values for PTHREAD_MUTEX_{NORMAL, RECURSIVE}#4943
JohnTitor merged 1 commit intorust-lang:mainfrom
aero-os:main

Conversation

@Andy-Python-Programmer
Copy link
Contributor

@Andy-Python-Programmer Andy-Python-Programmer commented Jan 27, 2026

Description

  • Fixes incorrect values for PTHREAD_MUTEX_{NORMAL, RECURSIVE} on Redox.
  • Adds other missing PTHREAD_MUTEX_* constants.

Sources

See https://gitlab.redox-os.org/redox-os/relibc/-/blob/5cadc9ebbd36f5294e08f67233928e5ad6f05670/src/header/pthread/mod.rs#L60

Checklist

  • Relevant tests in libc-test/semver have been updated. PTHREAD_MUTEX_ERRORCHECK, PTHREAD_MUTEX_ROBUST, PTHREAD_MUTEX_STALLED, PTHREAD_MUTEX_DEFAULT were added. These are not defined in libc-test/semver/unix.txt
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, thanks!

@JohnTitor
Copy link
Member

@jackpot51 could you double-check this PR when you have some time? Thanks in advance!

@JohnTitor JohnTitor added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jan 27, 2026
@JohnTitor JohnTitor added this pull request to the merge queue Jan 27, 2026
Merged via the queue into rust-lang:main with commit 3482c80 Jan 27, 2026
50 of 51 checks passed
@Andy-Python-Programmer
Copy link
Contributor Author

Thanks!

@jackpot51
Copy link
Contributor

Can a 0.2 rollup be done soon?

@JohnTitor
Copy link
Member

Can a 0.2 rollup be done soon?

Short answer is yes™! We have an issue around the time64 change (#4939) and I'd like to cut a new release as soon as it's resolved.

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Feb 9, 2026
@tgross35 tgross35 mentioned this pull request Feb 9, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 9, 2026
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-redox O-unix stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants