Fix const for field tm_zone in struct tm#4948
Merged
tgross35 merged 1 commit intorust-lang:mainfrom Jan 28, 2026
Merged
Conversation
Member
If it doesn't confuse downstream users, I'd prefer! I'm not sure but OpenBSD 7.8 doesn't have it yet? |
semarie
force-pushed
the
semarie/tm-tmzone
branch
from
dc4306b to
092f3e1
Compare
Contributor
Author
|
the change (on OpenBSD side) is for upcoming OpenBSD-7.9 |
JohnTitor
force-pushed
the
semarie/tm-tmzone
branch
from
092f3e1 to
e3e9a99
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tgross35
added
the
stable-nominated
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Feb 9, 2026
openbsd/src@4a796cf (backport <rust-lang#4948>) (cherry picked from commit 7be4e60)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 9, 2026
openbsd/src@4a796cf (backport <#4948>) (cherry picked from commit 7be4e60)
tgross35
added
stable-applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR makes the CI to ignore
tm_zonefield instruct tm. The const has been recently added in OpenBSD (see sources).The another way is to properly define
struct tmin OpenBSD, and move the currently global definition to each unix platform. It might be preferable. Feel free to ask for this way 😃Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI