android: add POSIX sysconf constants #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
Contributor
|
@lucab they weren't included simply because I didn't know which Android sdk to use as a reference. |
Contributor
Author
|
I think it is safe to add them now. The oldest supported android API at the moment is from 2015, and this commit predates it. Worst case is that older bionic will return |
Member
|
@bors: r+ Thanks! |
Contributor
|
📌 Commit 725608c has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
May 22, 2018
Contributor
|
💔 Test failed - status-travis |
Member
|
@bors: retry |
Contributor
bors
added a commit
that referenced
this pull request
May 22, 2018
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://android.googlesource.com/platform/bionic/+/1c19194c9d2518dbe86973cd313a277ecb70d75c%5E%21/libc/include/sys/sysconf.h