Create a new maint tool to prevent common publishing mistakes (#265)#266
Merged
Byron merged 5 commits intorust-lang:mainfrom Apr 5, 2026
Merged
Create a new maint tool to prevent common publishing mistakes (#265)#266Byron merged 5 commits intorust-lang:mainfrom
maint tool to prevent common publishing mistakes (#265)#266Byron merged 5 commits intorust-lang:mainfrom
Conversation
The zlib-ng vendored sources provide `src/zlib-ng/arch/arm/crc32_armv8.c`, but the cc-based build path still referenced `crc32_acle.c`. That breaks packaging and `cargo publish --dry-run` verification for `--no-default-features --features zlib-ng-no-cmake-experimental-community-maintained` on ARM targets. Switch the cc source list to `crc32_armv8` so the packaged crate matches the vendored source tree and the ARM release verification path succeeds. Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
…-lang#265) Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
Member
|
The other solution that might be simpler is setting the |
Member
|
And thanks for the fix! |
Member
Author
|
That would have been easier indeed 😁! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
maint publishtool