Add a count method to Source#329
Merged
Merged
Conversation
Contributor
Author
29 tasks
Thomasdezeeuw
approved these changes
Apr 29, 2019
Collaborator
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Source::count(&self) -> usizemethod to figure out how many key-value pairs to expect.I've also tried to clarify the expectation that subsequent calls to
Source::visitwill yield the same key-value pairs unless the visitor fails. A buggySource::visitwith the default implementation ofcountmay yield a different number of key-value pairs. Given that, we could make the method something likeSource::size_hint(&self) -> Option<usize>instead, but I think the fundamental requirement thatSource::visitpasses the same pairs to the visitor unless the visitor itself fails is reasonable and lets us add more useful methods likefor_eachthat don't have to return results. The reasonvisititself is fallible is so that a formatting or serialization error can be passed upstream for a logging framework to surface in some way.