Make it easier to create a Value from owned or erased external types#339
Merged
Conversation
that means doing two things: 1. allowing us to create a value with any lifetime from some owned primitive, like u8, bool etc 2. allowing us to create a value from some type that _can_ produce a concrete value we can use, but doesn't guarantee it will live as long as the value itself
Contributor
Author
|
I'll be a good citizen and add some tests for |
29 tasks
EFanZh
pushed a commit
to EFanZh/log
that referenced
this pull request
Jul 23, 2023
Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows consumers to work around
Value's required lifetime constraints in two ways:Primitivetype is all about.FillandSlottypes are all about.The
FillAPI is a more advanced initialization strategy (it's actually a kind of visitor that just tries very hard to look like initialization), so it isn't exported from thelog::kvmodule. Instead, this PR makes thevaluemodule public and leavesFillandSlotin there. We need something like this to be able to translate a&'kvs dyn tracing::Valueinto alog::kv::Value<'kvs>.