Skip to content

Remove deprecated Error::description #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KodrAus merged 1 commit into from
Dec 18, 2019
Merged

Remove deprecated Error::description #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/kv/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,7 @@ mod std_support {
}
}

impl error::Error for Error {
fn description(&self) -> &str {
"key values error"
}
}
impl error::Error for Error {}

impl From<io::Error> for Error {
fn from(err: io::Error) -> Self {
Expand Down
14 changes: 3 additions & 11 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,11 +1330,7 @@ impl fmt::Display for SetLoggerError {

// The Error trait is not available in libcore
#[cfg(feature = "std")]
impl error::Error for SetLoggerError {
fn description(&self) -> &str {
SET_LOGGER_ERROR
}
}
impl error::Error for SetLoggerError {}

/// The type returned by [`from_str`] when the string doesn't match any of the log levels.
///
Expand All @@ -1351,11 +1347,7 @@ impl fmt::Display for ParseLevelError {

// The Error trait is not available in libcore
#[cfg(feature = "std")]
impl error::Error for ParseLevelError {
fn description(&self) -> &str {
LEVEL_PARSE_ERROR
}
}
impl error::Error for ParseLevelError {}

/// Returns a reference to the logger.
///
Expand Down Expand Up @@ -1579,7 +1571,7 @@ mod tests {
use std::error::Error;
let e = SetLoggerError(());
assert_eq!(
e.description(),
&e.to_string(),
"attempted to set a logger after the logging system \
was already initialized"
);
Expand Down