Conversation
serde_core is the same as the serde library it's replacing, but it only contains the traits, not the code for the derive macros, resulting in faster compilitation. See the crate documentation (https://crates.io/crates/serde_core) for more information.
The kv* features that are enable also enable the dependencies.
Thomasdezeeuw
commented
Nov 28, 2025
| # This is here to not break backwards compatibility with the implicit feature | ||
| # that enables support for serde based on the dependency name. Since we're now | ||
| # using serde_core, the implicit feature was renamed, this adds back an alias. | ||
| serde = ["serde_core"] |
Collaborator
Author
There was a problem hiding this comment.
Also see the failed CI: https://github.com/rust-lang/log/actions/runs/19773284438/job/56661471080?pr=712.
Collaborator
Author
|
I'll send more prs for the failing lints and MSRV as neither test failure is specific to this pr. |
KodrAus
approved these changes
Nov 29, 2025
Contributor
KodrAus
left a comment
KodrAus
left a comment
There was a problem hiding this comment.
Thanks @Thomasdezeeuw! I'll merge all these in, then look at CI in a single pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serde_core is the same as the serde library it's replacing, but it only contains the traits, not the code for the derive macros, resulting in faster compilitation. See the crate documentation
(https://crates.io/crates/serde_core) for more information.