stabilize s390x vector registers#2215
Open
folkertdev wants to merge 1 commit intorust-lang:masterfrom
Open
Conversation
rustbot
added
the
S-waiting-on-review
folkertdev
commented
Mar 22, 2026
Comment on lines
-629
to
+632
| | s390x | `vreg` | `v[0-31]` | Only clobbers | | ||
| | s390x | `vreg` | `v[0-31]` | `v` | |
Comment on lines
+321
to
+322
| > [!NOTE] | ||
| > If the value's type is smaller than the register, the value of the upper bits is platform-specific. Some targets zero out the upper bits, while others leave them untouched. |
Contributor
Author
There was a problem hiding this comment.
This came up in the stabilization PR. Amanieu mentions that aarch64 zeros the upper bits, while s390x does not touch them.
This might need some re-phrasing, but I think it's useful to include to prevent future confusion.
folkertdev
force-pushed
the
stabilize-s390x-vector-registers
branch
from
a0c1541 to
41a2fc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc rust-lang/rust#154184