Skip to content

Mention that FCP approval is not code review approval and nothing is merged automatically #339

@Noratrieb

Description

@Noratrieb

rfcbot says

The final comment period, with a disposition to merge, as per the rust-lang/rust#146561 (comment), is now complete.
As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.
This will be merged soon.

Which is bad wording for PRs, it implies that the PR will magically be merged soon. It should say that the team has approved the idea of the change, but the change still needs to follow the regular code review process for approval.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions