Cursor position is pretty weird in inlay hints

[davyzhang]

I actually place it after p so it should look like p|, instead, it was placed after the whole inlay hints.
If I type something, it correctly put the characters behind "p" though.
In this case, it is trivial.

But if the inlay hints are long, this would be awkward to handle. See the demo below

[killercup]

I guess this is a VSCode constraint, especially since decorations aren't really meant to be used like this. An easy way to make this a bit better might be to shorten the max length of inlay hints, i.e. showing just RootNode<…> in your second case. Not sure if people will like this trade-off, though.

[SomeoneToIgnore]

That will remain as is for now, unfortunately.

Here's a VS Code issue about true parameter hints support: microsoft/vscode#16221

[matklad]

What we might want to try is attaching the decoration before the following token, and not after the binding. Not sure if it's a good idea though.

[killercup]

inb4

let really_long_identifier_that_is_very_descriptive
    = "but it also like to have my equal signs on the next line";

Edit: Fine, @matklad wins

[matklad]

@killercup the next token here is whitespace ;)

[p-avital]

What we might want to try is attaching the decoration before the following token, and not after the binding. Not sure if it's a good idea though.

I think I've tried that on the rls-vscode client, and the cursor still insists on going to the right of the decoration. Might be wrong though, so do check it, should be a quick enough hack to try :)

Also, keeping the decoration tied to the variable name makes hovering over the hint behave the same as Hovering over the variable, which is more convenient and might be used to show a more detailed type hint (without the abridgements for example)

[matklad]

Thanks for the input @p-avital

Closing as an upstream issue then!

Just a reminder, it's possible to completely disable hints in the settings

[corneliusroemer]

I think the rust-analyzer extension has switched to using native type hints recently. So maybe some of these issues can now be addressed?
See #2797, #11445

[Veykril]

This is still a client side issue with VSCode, not something r-a has control over