Skip to content

Add 'Use of AI tools' section to CONTRIBUTING.md#21314

Merged
Veykril merged 1 commit intorust-lang:masterfrom
Veykril:push-kywtpqlnwztr
Dec 21, 2025
Merged

Add 'Use of AI tools' section to CONTRIBUTING.md#21314
Veykril merged 1 commit intorust-lang:masterfrom
Veykril:push-kywtpqlnwztr

Conversation

@Veykril
Copy link
Member

@Veykril Veykril commented Dec 21, 2025

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2025
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Veykril Veykril enabled auto-merge December 21, 2025 12:29
@Veykril Veykril added this pull request to the merge queue Dec 21, 2025
Merged via the queue into rust-lang:master with commit 7fdd04b Dec 21, 2025
15 checks passed
@Veykril Veykril deleted the push-kywtpqlnwztr branch December 21, 2025 12:44
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2025

AI tool use is not discouraged on the rust-analyzer codebase, as long as it meets our quality standards.
We kindly ask you to disclose usage of AI tools in your contributions.
If you used them without disclosing it, we may reject your contribution on that basis alone due to the assumption that you likely not reviewed your own submission (so why should we?).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you used them without disclosing it, we may reject your contribution on that basis alone due to the assumption that you likely not reviewed your own submission (so why should we?).
If you used them without disclosing it, we may reject your contribution on that basis alone due to the assumption that you likely have not reviewed your own submission (so why should we?).

Wilfred added a commit to Wilfred/rust-analyzer that referenced this pull request Mar 2, 2026
rust-analyzer allows AI usage (see rust-lang#21314), but requires contributors
to declare usage. This adds a rule file that improves LLM output
quality and instructs the LLM to declare usage in commit messages.

I've written the rules in CLAUDE.md, but also symlinked it to
AGENTS.md so other LLM tools pick it up.

 ## Rules file contents

(1) Instructions for both humans and AIs to declare AI usage.

(2) Relevant commands for testing, linting and codegen.

Note that I deliberately didn't include an overview of the project
structure on a folder-by-folder basis. This can go stale, and there's
some evidence that project structure can hurt LLM output quality
overall.

See the following paper:

> Evaluating AGENTS.md:
> Are Repository-Level Context Files Helpful for Coding Agents?
> https://arxiv.org/pdf/2602.11988

 ## Testing

I exercised this change with the following contrived prompt. Note that
in practice rust-analyzer is hitting review scaling limits for new
code actions, but it was easy to test end-to-end.

> Add a new code action that replaces the content of a string literal
> with the text "banana".
...
> commit it

This produced a functional code action with both Codex and Claude, and
in both cases the commit message mentioned that it was AI
generated. Example commit message:

    Add "Replace string with banana" code action

    Add a new assist that replaces a string literal's content with "banana"
    when the cursor is on a STRING token.

    AI: Generated with Claude Code (claude-opus-4-6).

 ## AI Usage Disclosures

I wrote the first draft of the rules file with Opus 4.6, manually
reviewed everything.
Wilfred added a commit to Wilfred/rust-analyzer that referenced this pull request Mar 2, 2026
rust-analyzer allows AI usage (see rust-lang#21314), but requires contributors
to declare usage. This adds a rule file that improves LLM output
quality and instructs the LLM to declare usage in commit messages.

I've written the rules in CLAUDE.md, but also symlinked it to
AGENTS.md so other LLM tools pick it up.

## Rules file contents

(1) Instructions for both humans and AIs to declare AI usage.

(2) Relevant commands for testing, linting and codegen.

Note that I deliberately didn't include an overview of the project
structure on a folder-by-folder basis. This can go stale, and there's
some evidence that project structure can hurt LLM output quality
overall.

See the following paper:

> Evaluating AGENTS.md:
> Are Repository-Level Context Files Helpful for Coding Agents?
> https://arxiv.org/pdf/2602.11988

## Testing

I exercised this change with the following contrived prompt. Note that
in practice rust-analyzer is hitting review scaling limits for new
code actions, but it was easy to test end-to-end.

> Add a new code action that replaces the content of a string literal
> with the text "banana".
...
> commit it

This produced a functional code action with both Codex and Claude, and
in both cases the commit message mentioned that it was AI
generated. Example commit message:

    Add "Replace string with banana" code action

    Add a new assist that replaces a string literal's content with "banana"
    when the cursor is on a STRING token.

    AI: Generated with Claude Code (claude-opus-4-6).

I confirmed that the code action worked by testing a rust-analyzer
build in Emacs, and also confirmed that the generated tests looked
sensible.

## AI Usage Disclosures

I wrote the first draft of the rules file with Opus 4.6, manually
reviewed everything.
Wilfred added a commit to Wilfred/rust-analyzer that referenced this pull request Mar 3, 2026
rust-analyzer allows AI usage (see rust-lang#21314), but requires contributors
to declare usage. This adds a rule file that improves LLM output
quality and instructs the LLM to declare usage in commit messages.

I've written the rules in CLAUDE.md, but also symlinked it to
AGENTS.md so other LLM tools pick it up.

## Rules file contents

(1) Instructions for both humans and AIs to declare AI usage.

(2) Relevant commands for testing, linting and codegen.

Note that I deliberately didn't include an overview of the project
structure on a folder-by-folder basis. This can go stale, and there's
some evidence that project structure can hurt LLM output quality
overall.

See the following paper:

> Evaluating AGENTS.md:
> Are Repository-Level Context Files Helpful for Coding Agents?
> https://arxiv.org/pdf/2602.11988

## Testing

I exercised this change with the following contrived prompt. Note that
in practice rust-analyzer is hitting review scaling limits for new
code actions, but it was easy to test end-to-end.

> Add a new code action that replaces the content of a string literal
> with the text "banana".
...
> commit it

This produced a functional code action with both Codex and Claude, and
in both cases the commit message mentioned that it was AI
generated. Example commit message:

    Add "Replace string with banana" code action

    Add a new assist that replaces a string literal's content with "banana"
    when the cursor is on a STRING token.

    AI: Generated with Claude Code (claude-opus-4-6).

I confirmed that the code action worked by testing a rust-analyzer
build in Emacs, and also confirmed that the generated tests looked
sensible.

## AI Usage Disclosures

I wrote the first draft of the rules file with Opus 4.6, manually
reviewed everything.
@lnicola
Copy link
Member

lnicola commented Mar 11, 2026

@McSinyx moving this here so we don't spam almost 700 people.

As far as I know, the LLM-generated contributions to r-a have been mostly limited, and I'm not personally worried about license laundering in those specific cases, or in general (since people seem to have taken to calling clean-room reverse engineering license laundering). If you have specific concerts about copyrighted code being used in rust-analyzer, please feel free to point to them.

The Rust project might take a stance on them in the near future, and if they get banned, we will follow suit. In the meanwhile, we're not going to reject good contributions.

As for Guix, I have no stake in it so I'm not going to tell you what to do, but to put it into perspective, projects like Firefox and the Linux kernel probably contain more LLM-generated code than rust-analyzer itself.

@McSinyx
Copy link

McSinyx commented Mar 11, 2026

moving this here so we don't spam almost 700 people.

I'm so sorry, @lnicola, I did not know that there are 700 people watching the other PR.

As for Guix, I have no stake in it so I'm not going to tell you what to do, but to put it into perspective, projects like Firefox and the Linux kernel probably contain more LLM-generated code than rust-analyzer itself.

Indeed, I was just gathering information, as it's very unsure if there's anything actionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants