Remove incorrect size_t_is_usize check#3313
Merged
emilio merged 1 commit intorust-lang:mainfrom Nov 9, 2025
Merged
Conversation
emilio
approved these changes
Nov 8, 2025
Contributor
Author
|
Thanks a lot! Should I rebase on main to trigger a new CI run? I think this is not getting into the merge queue because of the failed CI. |
Don't require that the alignment of `size_t` equals pointer size when using the `size_t_is_usize` option. The purpose of this check was to make sure that `size_t` and `uintptr_t` are the same type, but the alignment and size don't have to match for that to be true. The code still checks that `size_t` has the same size as a pointer. Clang's C API doesn't expose the target pointer alignment, so just remove the assert. Fixes rust-lang#3312
Contributor
|
I think it should work now. Thanks for the patch and the extra clippy fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't require that the alignment of
size_tequals pointer size when using thesize_t_is_usizeoption. The purpose of this check was to make sure thatsize_tanduintptr_tare the same type, but the alignment and size don't have to match for that to be true. The code still checks thatsize_thas the same size as a pointer.Clang's C API doesn't expose the target pointer alignment, so just remove the assert.
Fixes #3312