Skip to content

Conversation

@Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Dec 2, 2022

fixes #10017


changelog: Sugg: [zero_ptr]: Now suggests core:: paths for no_std crates
#10023

@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2022

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 2, 2022
@xFrednet
Copy link
Contributor

xFrednet commented Dec 2, 2022

The CI failed due to clippy::module_name_repetitions. Off-topic, but do we maybe want to move that lint to restriction I almost always enable that one ^^

I'll try to review this over the weekend, otherwise early next week :)

@xFrednet
Copy link
Contributor

xFrednet commented Dec 5, 2022

Excellent, thank you for the update!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 5, 2022

📌 Commit 6ba2cda has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 5, 2022

⌛ Testing commit 6ba2cda with merge fc97c4c...

bors added a commit that referenced this pull request Dec 5, 2022
Fix `zero_ptr` suggestion for `no_std` crates

fixes #10017

---

changelog: [`zero_ptr`]: Now suggests `core::` paths for `no_std` crates
[#10023](#10023)
@bors
Copy link
Contributor

bors commented Dec 5, 2022

💔 Test failed - checks-action_test

@xFrednet xFrednet added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Dec 6, 2022
@xFrednet
Copy link
Contributor

xFrednet commented Dec 6, 2022

@bors retry

@bors
Copy link
Contributor

bors commented Dec 6, 2022

⌛ Testing commit 6ba2cda with merge 4129054...

@bors
Copy link
Contributor

bors commented Dec 6, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 4129054 to master...

@bors bors merged commit 4129054 into rust-lang:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: The marked PR was approved and is only waiting bors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FP zero_ptr in no_std contest

4 participants