Add support for stable versions before 1.8.0 #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
the
S-waiting-on-review
Contributor
Author
|
r? @Kobzol |
Kobzol
approved these changes
Oct 15, 2024
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
Thank you! It's great that we now have all the releases on that page 🎉
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add support for stable versions before 1.8.0.
Why
I added Archive of Rust Stable Standalone Installers page in #733 and #770.
Currently it works for all versions >= 1.8.0. Versions <= 1.7.0 do not have manifests. See Zulip for details.
So in this PR I hard code the available platforms for stable versions before 1.8.0. I got the list of the supported platforms for each version by trying to download (similar to what rustup does for them). I tested that I am able to download the artifacts from the final Forge page.
Screenshot with versions 1.0.0 and 1.1.0 available: