-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Closed
Labels
P-highHigh priorityHigh priorityregression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Description
This is a tracking issue for the tasks to revert cargo check and --crate-type=metadata in the Rust 1.15 release branch. currently --crate-type=metadata is on the beta branch of this repository and cargo check is itself in the rust-1.15.0 branch of the Cargo repository.
Unfortunately there have been a number of bugs associated with cargo check since first implemented:
- Cargo check gives error where cargo build does not cargo#3461
- Cargo check on nightly seems to have problems with re-exported types cargo#3464
cargo checkcompiles library object code if a binary exists cargo#3418cargo checkrecompiles dependencies when checking lib and bin separately cargo#3421cargo checkfails oddly on binaries cargo#3419- --crate-type metadata overrides binary-ness of crates #38273
All of these issues, however, should be fixed by these two changes:
We need to fix the issues on beta in one way or another, and today the tools team decided to go ahead and revert the changes on beta and let the bug fixes ride the trains to stable in the Rust 1.16 release. There's two things that need to happen to close out this issue:
- Don't accept
--crate-type=metadatain the compiler - Remove --crate-type=metadata from beta #38668 - Remove the
cargo checkcommand from Cargo - Remove thecargo checksubcommand from Rust 1.15 cargo#3465
Metadata
Metadata
Assignees
Labels
P-highHigh priorityHigh priorityregression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.