Skip to content

Foreign type tests not covering all operations #64458

@bjorn3

Description

@bjorn3

For example foreign type pointer comparison is not tested. Also &(*val).0 where field 0 of *val is a foreign type is not tested. As a last thing pointer to *mut ForeignType casting it not tested.

These were all cases which were mishandled in rustc_codegen_cranelift. I didn't discover them until I tried to compile rustc itself using cg_clif.

Metadata

Metadata

Assignees

Labels

A-FFIArea: Foreign function interface (FFI)A-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.F-extern_types`#![feature(extern_types)]`T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.requires-nightlyThis issue requires a nightly compiler in some way. When possible, use a F-* label instead.

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions