Clean and tidy some traits #10967
Merged
Clean and tidy some traits #10967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanded, that is: - `AsOption` - `IntoOption` - `ToOption` - `AsEither` - `IntoEither` - `ToEither` - `AsResult` - `IntoResult` - `ToResult` These were defined for each other but never *used* anywhere. They are all trivial and so removal will have negligible effect upon anyone. `Either` has fallen out of favour (and its implementation of these traits of dubious semantics), `Option<T>` → `Result<T, ()>` was never really useful and `Result<T, E>` → `Option<T>` should now be done with `Result.ok()` (mirrored with `Result.err()` for even more usefulness). In summary, there's really no point in any of these remaining.
That is: - `ToStrConsume` → `IntoStr`; - `ToBytesConsume` → `IntoBytes`.
Contributor
|
👍 |
Member
|
These are some traits in some core modules, so this should be discussed a little bit. I am very much in favor of removing these traits. |
Member
|
I have added this to the agenda for tomorrow's meeting. |
bors
added a commit
that referenced
this pull request
Dec 17, 2013
…r=alexcrichton
### Remove {As,Into,To}{Option,Either,Result} traits.
Expanded, that is:
- `AsOption`
- `IntoOption`
- `ToOption`
- `AsEither`
- `IntoEither`
- `ToEither`
- `AsResult`
- `IntoResult`
- `ToResult`
These were defined for each other but never *used* anywhere. They are
all trivial and so removal will have negligible effect upon anyone.
`Either` has fallen out of favour (and its implementation of these
traits of dubious semantics), `Option<T>` → `Result<T, ()>` was never
really useful and `Result<T, E>` → `Option<T>` should now be done with
`Result.ok()` (mirrored with `Result.err()` for even more usefulness).
In summary, there's really no point in any of these remaining.
### Rename To{Str,Bytes}Consume traits to Into*.
That is:
- `ToStrConsume` → `IntoStr`;
- `ToBytesConsume` → `IntoBytes`.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
New lints ['`needless_pub_self`], [`pub_with_shorthand`] and [`pub_without_shorthand`] Closes rust-lang#10963 Closes rust-lang#10964 changelog: New lints ['`needless_pub_self`], [`pub_with_shorthand`] and [`pub_without_shorthand`]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove {As,Into,To}{Option,Either,Result} traits.
Expanded, that is:
AsOptionIntoOptionToOptionAsEitherIntoEitherToEitherAsResultIntoResultToResultThese were defined for each other but never used anywhere. They are
all trivial and so removal will have negligible effect upon anyone.
Eitherhas fallen out of favour (and its implementation of thesetraits of dubious semantics),
Option<T>→Result<T, ()>was neverreally useful and
Result<T, E>→Option<T>should now be done withResult.ok()(mirrored withResult.err()for even more usefulness).In summary, there's really no point in any of these remaining.
Rename To{Str,Bytes}Consume traits to Into*.
That is:
ToStrConsume→IntoStr;ToBytesConsume→IntoBytes.