Skip to content

Conversation

@alex
Copy link
Member

@alex alex commented May 15, 2023

This is pretty heavily cargo-culted, hopefully I didn't screw it up too badly.

@rustbot
Copy link
Collaborator

rustbot commented May 15, 2023

r? @pietroalbini

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 15, 2023
@tmiasko
Copy link
Contributor

tmiasko commented May 18, 2023

Supported sanitizers also need to be declared in the target spec, for example:

base.supported_sanitizers = SanitizerSet::ADDRESS
| SanitizerSet::CFI
| SanitizerSet::LEAK
| SanitizerSet::MEMORY
| SanitizerSet::THREAD;

@rustbot
Copy link
Collaborator

rustbot commented May 22, 2023

These commits modify compiler targets.
(See the Target Tier Policy.)

@alex
Copy link
Member Author

alex commented May 22, 2023

Done, thanks!

@pietroalbini
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 24, 2023

📌 Commit 12fd46d has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2023
@bors
Copy link
Collaborator

bors commented May 25, 2023

⌛ Testing commit 12fd46d with merge 776f222...

@bors
Copy link
Collaborator

bors commented May 25, 2023

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 776f222 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 25, 2023
@bors bors merged commit 776f222 into rust-lang:master May 25, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 25, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (776f222): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.6% [3.6%, 3.6%] 1
Regressions ❌
(secondary)
1.7% [1.7%, 1.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.6% [3.6%, 3.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 646.176s -> 646.814s (0.10%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants