rustc: remove the explicit count from the lang_item macro. #11657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use a secondary macro to calculate the count from the information we're already having to pass to the lang items macro.
Member
|
I did this as part of #11409 as well (https://github.com/mozilla/rust/pull/11409/files#diff-855fca46fb86dbacaee6e1226c2bd4a7L38), but it looks like it's taking awhile to land... |
bors
added a commit
that referenced
this pull request
Jan 20, 2014
We can use a secondary macro to calculate the count from the information we're already having to pass to the lang items macro.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 17, 2024
cfg Attribute Stripping for Proc Macro Expansion This will attempt to process cfg attributes and cfg_attr attributes for proc macro expansion.  Closes rust-lang#8434 , rust-lang#11657, and rust-lang#13904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use a secondary macro to calculate the count from the information
we're already having to pass to the lang items macro.