Rename Copyable to Cloneable to ensure consistency with the Clone trait #11893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
beautiful |
Contributor
Author
|
I was not sure about what to do for std::util::NonCopyable though, but as its usage seems to be reserved to testing purposes I chose to let it live. I can still add a commit if you like. |
Contributor
|
@Armavica |
bors
added a commit
that referenced
this pull request
Jan 30, 2014
I found awkward to have `MutableCloneableVector` and `CloneableIterator` on the one hand, and `CopyableVector` etc. on the other hand. The concerned traits are: * `CopyableVector` --> `CloneableVector` * `OwnedCopyableVector` --> `OwnedCloneableVector` * `ImmutableCopyableVector` --> `ImmutableCloneableVector` * `CopyableTuple` --> `CloneableTuple`
Contributor
|
|
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…arm, r=Veykril feat: add fold range for multi line match arm list fix: rust-lang#11893
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 1, 2023
Fix rust-lang#11893 Trigerring on expressions returning `()` uses the arguments of the `map_or_else()` rewrite only for their side effects. This does lead to code which is harder to read than the original.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 1, 2023
`option_if_let_else`: do not trigger on expressions returning `()` Fix rust-lang#11893 Trigerring on expressions returning `()` uses the arguments of the `map_or_else()` rewrite only for their side effects. This does lead to code which is harder to read than the original. changelog: [`option_if_let_else`]: do not trigger on unit expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found awkward to have
MutableCloneableVectorandCloneableIteratoron the one hand, andCopyableVectoretc. on the other hand.The concerned traits are:
CopyableVector-->CloneableVectorOwnedCopyableVector-->OwnedCloneableVectorImmutableCopyableVector-->ImmutableCloneableVectorCopyableTuple-->CloneableTuple