Skip to content

shallow resolve in orphan check #124623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
May 2, 2024
Merged

shallow resolve in orphan check #124623

bors merged 1 commit into from
May 2, 2024

Conversation

@lcnr
Copy link
Contributor

@lcnr lcnr commented May 2, 2024 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented May 2, 2024

Failed to set assignee to compiler-errrs: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 2, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 2, 2024

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@compiler-errors compiler-errors self-assigned this May 2, 2024
@rustbot

This comment was marked as off-topic.

Sign in to view
@rustbot

This comment was marked as off-topic.

Sign in to view
compiler-errors
compiler-errors approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if ci green

@lcnr
Copy link
Contributor Author

lcnr commented May 2, 2024

@bors r=compiler-errors rollup

@bors
Copy link
Collaborator

bors commented May 2, 2024

📌 Commit c4e882f has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2024
@fmease fmease mentioned this pull request May 2, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request May 2, 2024
Merged
@bors bors merged commit fe62bc5 into rust-lang:master May 2, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 2, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request May 2, 2024
Closed
@lcnr lcnr deleted the coherence-uwu branch May 2, 2024 23:17
@fmease fmease mentioned this pull request May 3, 2024
Closed
@compiler-errors compiler-errors mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.80.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lcnr @rustbot @bors @compiler-errors