Uplift FnSig to rustc_type_ir#125157
Closed
compiler-errors wants to merge 1 commit intorust-lang:masterfrom
Closed
Uplift FnSig to rustc_type_ir#125157compiler-errors wants to merge 1 commit intorust-lang:masterfrom
FnSig to rustc_type_ir#125157compiler-errors wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors try @rust-timer queue Removed some |
Collaborator
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
compiler-errors
force-pushed
the
uplift-fn-sig
branch
from
90c90af to
f6bfc1e
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2024
Uplift `FnSig` to `rustc_type_ir` :3 r? lcnr
Collaborator
Contributor
Author
|
@bors r- |
bors
added
S-waiting-on-author
lcnr
reviewed
May 15, 2024
| } | ||
|
|
||
| pub trait Abi<I: Interner<Abi = Self>>: Copy + Debug + Hash + Eq { | ||
| // is `extern "Rust"`? |
Contributor
There was a problem hiding this comment.
Suggested change
| // is `extern "Rust"`? | |
| /// Whether this ABI is `extern "Rust"`. |
Contributor
|
r=me after nit + CI |
Contributor
Author
|
@bors retry |
bors
added
S-waiting-on-bors
Member
|
@bors r- retry (bors seems to think this PR is approved and is not running a try-only build?) |
bors
added
S-waiting-on-author
Contributor
Author
|
I feel like this branch is beyond repair |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 16, 2024
…=lcnr Uplift `FnSig` into `rustc_type_ir` (redux) Since the last one got so messed up with `try` build. rust-lang#125157 (comment) r? lcnr
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2024
Rollup merge of rust-lang#125170 - compiler-errors:uplift-fn-sig-2, r=lcnr Uplift `FnSig` into `rustc_type_ir` (redux) Since the last one got so messed up with `try` build. rust-lang#125157 (comment) r? lcnr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:3
r? lcnr