Skip to content

bootstrap: improve error recovery flags to curl #129134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 5 commits into from
Aug 25, 2024
Merged

bootstrap: improve error recovery flags to curl #129134

bors merged 5 commits into from
Aug 25, 2024

Conversation

@lolbinarycat
Copy link
Contributor

@lolbinarycat lolbinarycat commented Aug 15, 2024

alternative to #128459

fixes #110178

r? @Kobzol

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Kobzol (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 15, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Kobzol
Kobzol reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems like a much less invasive change! Left some comments.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
Kobzol
Kobzol reviewed Aug 24, 2024
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol
Copy link
Member

Kobzol commented Aug 24, 2024

Btw, you can run ./x test tidy to run the fast CI check that is performed after each push to a PR. And ./x fmt to reformat code.

@lolbinarycat
Copy link
Contributor Author

lolbinarycat commented Aug 24, 2024

I know, but tidy takes an eternity to run on a hdd system.

@lolbinarycat
Copy link
Contributor Author

lolbinarycat commented Aug 24, 2024

i think there's actually a bug in get_git_modified_files, actually, it's reporting a number that way too high. probably because the current branch is actually behind the local master branch, since i haven't rebased it since the last git pull.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat
Copy link
Contributor Author

lolbinarycat commented Aug 24, 2024

i think there's actually a bug in get_git_modified_files, actually, it's reporting a number that way too high. probably because the current branch is actually behind the local master branch, since i haven't rebased it since the last git pull.

not a bug, just extremely bad ux. see #129528

@Kobzol
Copy link
Member

Kobzol commented Aug 24, 2024

Thanks! You can r=me once PR CI is green.

@bors delegate+

@bors
Copy link
Collaborator

bors commented Aug 24, 2024

✌️ @lolbinarycat, you can now approve this pull request!

If @Kobzol told you to "r=me" after making some further change, please make that change, then do @bors r=@Kobzol

@lolbinarycat
Copy link
Contributor Author

lolbinarycat commented Aug 25, 2024

@bors r=@Kobzol

@bors
Copy link
Collaborator

bors commented Aug 25, 2024

📌 Commit 56adf87 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2024
@onur-ozkan onur-ozkan mentioned this pull request Aug 25, 2024
Closed
@tgross35 tgross35 mentioned this pull request Aug 25, 2024
Closed
This was referenced Aug 25, 2024
Closed
Closed
Merged
@bors bors merged commit 8e27d4c into rust-lang:master Aug 25, 2024
@rustbot rustbot added this to the 1.82.0 milestone Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.82.0

Development

Successfully merging this pull request may close these issues.

bootstrap doesn't retry downloads that fail with a non-HTTP error

5 participants

@lolbinarycat @rustbot @rust-log-analyzer @Kobzol @bors