Allow #[link(kind = "dylib")] without a name #131966
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
ChrisDenton
force-pushed
the
bare-link
branch
from
b480b82 to
701594c
Compare
Member
Author
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 20, 2024
Allow #[link(kind = "dylib")] without a name This PR allows `#[link(kind = "dylib")]` without a library name (see the [dllimport RFC](https://rust-lang.github.io/rfcs/1717-dllimport.html) for how this affects `extern {}` blocks). This will need a lang fcp but I wanted to investigate how feasible this is. I want a bare `kind` to act the same as any other `#[link]` for the purposes of applying (or not) dllimport so it gets added to the same array. However, this then means they need to be filtered out from normal queries. To facilitate this I've added a wrapper type for the `NativeLib` container and a separate query for `is_dllimport`. try-job: x86_64-msvc try-job: x86_64-mingw
Collaborator
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
ChrisDenton
force-pushed
the
bare-link
branch
from
701594c to
a1ec55a
Compare
Member
Author
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 20, 2024
Allow #[link(kind = "dylib")] without a name This PR allows `#[link(kind = "dylib")]` without a library name (see the [dllimport RFC](https://rust-lang.github.io/rfcs/1717-dllimport.html) for how this affects `extern {}` blocks). This will need a lang fcp but I wanted to investigate how feasible this is. I want a bare `kind` to act the same as any other `#[link]` for the purposes of applying (or not) dllimport so it gets added to the same array. However, this then means they need to be filtered out from normal queries. To facilitate this I've added a wrapper type for the `NativeLib` container and a separate query for `is_dllimport`. try-job: x86_64-msvc try-job: x86_64-mingw
Collaborator
Collaborator
|
☀️ Try build successful - checks-actions |
4 tasks
ChrisDenton
force-pushed
the
bare-link
branch
from
a1ec55a to
a1b2f15
Compare
Contributor
|
Does this need a compiler review yet? |
Member
Author
|
Lang haven't yet considered this. |
Member
Author
|
I'll close this. While this approach can work, I'd prefer to do it a different way. This is ultimately an ABI concern rather than anything to do with native libs per se. Well I guess it can be thought of as referencing an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
#[link(kind = "dylib")]without a library name (see the dllimport RFC for how this affectsextern {}blocks).This will need a lang fcp but I wanted to investigate how feasible this is. I want a bare
kindto act the same as any other#[link]for the purposes of applying (or not) dllimport so the kind gets added to the sameNativeLibarray. However, this then means they need to be filtered out from normal queries. To facilitate this I've added a wrapper type for theNativeLibcontainer and a separate query foris_dllimport.try-job: x86_64-msvc
try-job: x86_64-mingw