Move task::task() to TaskBuilder::new() #13675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Legit error. |
The constructor for `TaskBuilder` is being changed to an associated function called `new` for consistency with the rest of the standard library. Closes rust-lang#13666 [breaking-change]
bors
added a commit
that referenced
this pull request
Apr 24, 2014
The constructor for `TaskBuilder` is being changed to an associated function called `new` for consistency with the rest of the standard library. Closes #13666 [breaking-change]
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 20, 2025
…item groups optional (rust-lang#13718) From feedback to the `arbitrary_source_item_ordering` lint after its inclusion in clippy 1.82, making alphabetic ordering within module item groups has turned out to be the most requested improvement. With this improvement, it is possible to make the lint perform certain top-level structural checks on modules (e.g. use statements and module inclusions at the top), but still leaving everything else up to the developer. Implements parts of the suggestions from rust-lang#13675. A catch-all-group is still to be implemented. changelog: [`arbitrary_source_item_ordering`]: Make alphabetic ordering in module item groups optional (off by default)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor for
TaskBuilderis being changed to an associatedfunction called
newfor consistency with the rest of the standardlibrary.
Closes #13666
[breaking-change]