Skip to content

Add missing regression GUI test #139488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
Apr 10, 2025
Merged

Add missing regression GUI test #139488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39c6b6c
Fix CSS
GuillaumeGomez Apr 7, 2025
30f56df
Add regression test for #139282
GuillaumeGomez Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/librustdoc/html/static/css/rustdoc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1447,7 +1447,7 @@ so that we can apply CSS-filters to change the arrow color in themes */
cursor: pointer;
}
.setting-check input {
flex-shrink: 0,
flex-shrink: 0;
}

.setting-radio input:checked {
Expand Down
14 changes: 14 additions & 0 deletions tests/rustdoc-gui/settings.goml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,13 @@ compare-elements-position: (".sub form", "#settings", ["x"])
// Check that setting-line has the same margin in this mode as in the popover.
assert-css: (".setting-line", {"margin": |setting_line_margin|})

// We will check that the checkboxes size doesn't change either.
assert-size: (
"#settings label > input[type='checkbox']",
{"width": 19, "height": 19},
ALL,
)

// We now check the display with JS disabled.
assert-false: "noscript section"
javascript: false
Expand All @@ -327,3 +334,10 @@ reload:
set-window-size: (300, 1000)
wait-for: "#settings"
assert-css: (".setting-radio", {"cursor": "pointer"})

// We ensure that the checkboxes size didn't change.
assert-size: (
"#settings label > input[type='checkbox']",
{"width": 19, "height": 19},
ALL,
)
Loading