librustc: Use *signed* extension when converting enums to floats. #14786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Previously, constants used unsigned extension, while non-constants used signed extension. This unifies both paths to use signed extension. If this breaks your code, take a deep breath, go for a walk, and consider why you're relying on the sign extension semantics of enum-to-float casts. Closes rust-lang#8230. [breaking-change]
Contributor
Author
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Jun 11, 2014
If this breaks your code, take a deep breath, go for a walk, and consider why you're relying on the sign extension semantics of enum-to-float casts. [breaking-change] Closes #8230.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this breaks your code, take a deep breath, go for a walk, and
consider why you're relying on the sign extension semantics of
enum-to-float casts.
[breaking-change]
Closes #8230.