Fix suggestion for the cfg! macro
#148484
Merged
+46
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
JonathanBrouwer
commented
Nov 4, 2025
| Attribute(AttrStyle), | ||
| /// The suggestion is styled for an attribute embedded into another attribute. | ||
| /// For example, attributes inside `#[cfg_attr(true, attr(...)]`. | ||
| EmbeddedAttribute, |
Contributor
Author
There was a problem hiding this comment.
I invented the term "Embedded Attribute" here, feel free to bikeshed a better name
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 18, 2025
Rollup of 5 pull requests Successful merges: - #147887 (Improve the documentation of atomic::fence) - #148281 (repr(transparent) check: do not compute check_unsuited more than once) - #148484 (Fix suggestion for the `cfg!` macro) - #149057 (`rust-analyzer` subtree update) - #149061 (debug-assert FixedSizeEncoding invariant) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Nov 18, 2025
Rollup of 5 pull requests Successful merges: - #147887 (Improve the documentation of atomic::fence) - #148281 (repr(transparent) check: do not compute check_unsuited more than once) - #148484 (Fix suggestion for the `cfg!` macro) - #149057 (`rust-analyzer` subtree update) - #149061 (debug-assert FixedSizeEncoding invariant) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 19, 2025
Rollup merge of #148484 - JonathanBrouwer:wip_attr_style, r=jdonszelmann Fix suggestion for the `cfg!` macro r? `@jdonszelmann`
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Nov 19, 2025
Rollup of 5 pull requests Successful merges: - rust-lang/rust#147887 (Improve the documentation of atomic::fence) - rust-lang/rust#148281 (repr(transparent) check: do not compute check_unsuited more than once) - rust-lang/rust#148484 (Fix suggestion for the `cfg!` macro) - rust-lang/rust#149057 (`rust-analyzer` subtree update) - rust-lang/rust#149061 (debug-assert FixedSizeEncoding invariant) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#147887 (Improve the documentation of atomic::fence) - rust-lang#148281 (repr(transparent) check: do not compute check_unsuited more than once) - rust-lang#148484 (Fix suggestion for the `cfg!` macro) - rust-lang#149057 (`rust-analyzer` subtree update) - rust-lang#149061 (debug-assert FixedSizeEncoding invariant) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @jdonszelmann