Skip to content

Nvptx: Use llbc as default linker #148499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Dec 20, 2025
Merged

Nvptx: Use llbc as default linker #148499

bors merged 1 commit into from
Dec 20, 2025
+9 −16

Conversation

@kjetilkjeka
Copy link
Contributor

@kjetilkjeka kjetilkjeka commented Nov 4, 2025

@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@kjetilkjeka
Copy link
Contributor Author

kjetilkjeka commented Nov 4, 2025

@rustbot label +O-NVPTX

@rustbot rustbot added the O-NVPTX Target: the NVPTX LLVM backend for running rust on GPUs, https://llvm.org/docs/NVPTXUsage.html label Nov 4, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@kjetilkjeka kjetilkjeka force-pushed the nvptx_default_linker_llbc branch 2 times, most recently from 9468ec7 to 5af423e Compare November 4, 2025 21:36
@ehuss
Copy link
Contributor

ehuss commented Nov 4, 2025

r? compiler

@rustbot rustbot assigned madsmtm and unassigned ehuss Nov 4, 2025
@bjorn3
Copy link
Member

bjorn3 commented Nov 5, 2025

Bors forgot to notify you that this PR has merge conflicts.

@bors
Copy link
Collaborator

bors commented Nov 5, 2025

☔ The latest upstream changes (presumably #147645) made this pull request unmergeable. Please resolve the merge conflicts.

@kjetilkjeka kjetilkjeka force-pushed the nvptx_default_linker_llbc branch from 5af423e to 5cc74bc Compare November 5, 2025 09:36
@rustbot

This comment has been minimized.

Sign in to view
bjorn3
bjorn3 reviewed Nov 5, 2025
View reviewed changes
@kjetilkjeka kjetilkjeka force-pushed the nvptx_default_linker_llbc branch from 5cc74bc to 3a52529 Compare November 5, 2025 11:25
madsmtm
madsmtm reviewed Nov 15, 2025
View reviewed changes
Copy link
Contributor

@madsmtm madsmtm left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, feel free to r=me with comments resolved.

@bors delegate+

View changes since this review

@madsmtm madsmtm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-linkers Area: linkers... you gotta love linkers and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2025
@kjetilkjeka kjetilkjeka force-pushed the nvptx_default_linker_llbc branch from 3a52529 to 746acc4 Compare December 19, 2025 20:41
@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@kjetilkjeka
Copy link
Contributor Author

kjetilkjeka commented Dec 19, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 19, 2025

@kjetilkjeka: 🔑 Insufficient privileges: Not in reviewers

@kjetilkjeka
Copy link
Contributor Author

kjetilkjeka commented Dec 19, 2025

I'm not sure whether bors missed the delegate+ or if I messed something up.

In any case I fixed the review comments, made a final test with the rebase and review comments, and believe this one is ready for merging. But it seems like I need some help for the final review approval.

@madsmtm
Copy link
Contributor

madsmtm commented Dec 20, 2025

@bors try jobs=test-various
@bors r+ rollup

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Dec 20, 2025
@rust-bors
Auto merge of #148499 - kjetilkjeka:nvptx_default_linker_llbc, r=<try>
28dd0aa 
Nvptx: Use llbc as default linker

try-job: test-various
@rust-bors
Copy link

rust-bors bot commented Dec 20, 2025

☀️ Try build successful (CI)
Build commit: 28dd0aa (28dd0aa0d2207bd2a8562b513de6f6e5472fd4c0, parent: 806c2a35dcc1db7867864fea0a7a65554a5238b7)

@madsmtm
Copy link
Contributor

madsmtm commented Dec 20, 2025 •
edited
Loading

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 20, 2025

📌 Commit 746acc4 has been approved by madsmtm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 20, 2025
@madsmtm
Copy link
Contributor

madsmtm commented Dec 20, 2025

@bors rollup

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 20, 2025
@JonathanBrouwer
Rollup merge of rust-lang#148499 - kjetilkjeka:nvptx_default_linker_l…
3a98a12 
…lbc, r=madsmtm

Nvptx: Use llbc as default linker

The implementation of [MCP: Use `llvm-bitcode-linker` as the default linker for `nvptx64-nvidia-cuda`](rust-lang/compiler-team#927)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 20, 2025
Closed
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 20, 2025

I'm not sure whether bors missed the delegate+ or if I messed something up.

In any case I fixed the review comments, made a final test with the rebase and review comments, and believe this one is ready for merging. But it seems like I need some help for the final review approval.

You'd need to do bors r=madsmtm, doing r+ makes you the reviewer which is not allowed :p

bors added a commit that referenced this pull request Dec 20, 2025
@bors
Auto merge of #150186 - JonathanBrouwer:rollup-bd22oaq, r=JonathanBro…
9e1e77b 
…uwer

Rollup of 2 pull requests

Successful merges:

 - #148499 (Nvptx: Use llbc as default linker)
 - #150172 (Handle remapped paths correctly when generating "Source" links)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 20, 2025
@matthiaskrgr
Rollup merge of rust-lang#148499 - kjetilkjeka:nvptx_default_linker_l…
da4a7ec 
…lbc, r=madsmtm

Nvptx: Use llbc as default linker

The implementation of [MCP: Use `llvm-bitcode-linker` as the default linker for `nvptx64-nvidia-cuda`](rust-lang/compiler-team#927)
This was referenced Dec 20, 2025
Closed
Merged
bors added a commit that referenced this pull request Dec 20, 2025
@bors
Auto merge of #150190 - matthiaskrgr:rollup-tjdmcar, r=matthiaskrgr
b53da99 
Rollup of 4 pull requests

Successful merges:

 - #146747 (rustc_codegen_llvm: Tidying of `update_target_reliable_float_cfg`)
 - #148499 (Nvptx: Use llbc as default linker)
 - #148991 (miri genmc: fix exit() handling)
 - #150172 (Handle remapped paths correctly when generating "Source" links)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5a875b8 into rust-lang:main Dec 20, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 20, 2025
rust-timer added a commit that referenced this pull request Dec 20, 2025
@rust-timer
Unrolled build for #148499
effb515 
Rollup merge of #148499 - kjetilkjeka:nvptx_default_linker_llbc, r=madsmtm

Nvptx: Use llbc as default linker

The implementation of [MCP: Use `llvm-bitcode-linker` as the default linker for `nvptx64-nvidia-cuda`](rust-lang/compiler-team#927)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madsmtm madsmtm madsmtm left review comments

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@madsmtm madsmtm

Labels

A-linkers Area: linkers... you gotta love linkers O-NVPTX Target: the NVPTX LLVM backend for running rust on GPUs, https://llvm.org/docs/NVPTXUsage.html S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

8 participants

@kjetilkjeka @rustbot @rust-log-analyzer @ehuss @bjorn3 @bors @madsmtm @JonathanBrouwer