Skip to content

Fix error message for calling a non-tuple struct #149098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 2 commits into from
Nov 21, 2025
Merged

Fix error message for calling a non-tuple struct #149098

bors merged 2 commits into from
Nov 21, 2025

Conversation

@Jamesbarford
Copy link
Contributor

@Jamesbarford Jamesbarford commented Nov 19, 2025 •
edited
Loading

This feels a bit odd checking for "0" but I can't see how else to check for it being a Tuple

closes #148919

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

fmease
fmease reviewed Nov 19, 2025
View reviewed changes
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Nov 21, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 21, 2025

📌 Commit 3d33942 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 21, 2025
Merged
bors added a commit that referenced this pull request Nov 21, 2025
@bors
Auto merge of #149196 - GuillaumeGomez:rollup-pn0aoy3, r=GuillaumeGomez
27b076a 
Rollup of 7 pull requests

Successful merges:

 - #146978 (Emit error when using path-segment keyword as cfg pred)
 - #148719 (Allow unnormalized types in drop elaboration)
 - #148795 (add `rust.rustflags` and per target `rustflags` options to `bootstrap.toml`)
 - #149028 ([rustdoc] Remove `UrlFragment::render` method to unify `clean::types::links` and `anchor`)
 - #149043 ( rustdoc-json: add rlib path to ExternalCrate to enable robust crate resolution)
 - #149098 (Fix error message for calling a non-tuple struct)
 - #149151 (Add test for importing path-segment keyword)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b2f5cc7 into rust-lang:main Nov 21, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 21, 2025
rust-timer added a commit that referenced this pull request Nov 21, 2025
@rust-timer
Unrolled build for #149098
77350a2 
Rollup merge of #149098 - Jamesbarford:fix/148919-tuple-struct-lint, r=JonathanBrouwer

Fix error message for calling a non-tuple struct

This feels a bit odd checking for `"0"` but I can't see how else to check for it being a Tuple

closes #148919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmease fmease fmease left review comments

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

“cannot initialize a tuple struct which contains private fields” with no tuple struct involved

5 participants

@Jamesbarford @rustbot @JonathanBrouwer @bors @fmease