rustc_borrowck: Don't suggest changing closure param type not under user control #149107
+98
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
Enselic
force-pushed
the
option-inspect-mutation
branch
from
b49ff49 to
6c75dee
Compare
This comment has been minimized.
This comment has been minimized.
…ser control All removed suggestions in tests were invalid.
Enselic
force-pushed
the
option-inspect-mutation
branch
from
6c75dee to
f186e53
Compare
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 28, 2025
Rollup of 5 pull requests Successful merges: - #149087 (Stabilize `unchecked_neg` and `unchecked_shifts`) - #149107 (rustc_borrowck: Don't suggest changing closure param type not under user control) - #149323 (Use cg_llvm's target_config in miri) - #149380 (Run `eval_config_entry` on all branches so we always emit lints) - #149394 (add regression test for guard patterns liveness ICE) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 28, 2025
Rollup merge of #149107 - Enselic:option-inspect-mutation, r=jieyouxu rustc_borrowck: Don't suggest changing closure param type not under user control This changes output of a handful of tests more than the one added in the first commit, but as far as I can tell, all removed suggestions were invalid. Closes #128381 which is **D-invalid-suggestion** with two 👍-votes.
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Nov 28, 2025
Rollup of 5 pull requests Successful merges: - rust-lang/rust#149087 (Stabilize `unchecked_neg` and `unchecked_shifts`) - rust-lang/rust#149107 (rustc_borrowck: Don't suggest changing closure param type not under user control) - rust-lang/rust#149323 (Use cg_llvm's target_config in miri) - rust-lang/rust#149380 (Run `eval_config_entry` on all branches so we always emit lints) - rust-lang/rust#149394 (add regression test for guard patterns liveness ICE) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Dec 1, 2025
Rollup of 5 pull requests Successful merges: - rust-lang/rust#149087 (Stabilize `unchecked_neg` and `unchecked_shifts`) - rust-lang/rust#149107 (rustc_borrowck: Don't suggest changing closure param type not under user control) - rust-lang/rust#149323 (Use cg_llvm's target_config in miri) - rust-lang/rust#149380 (Run `eval_config_entry` on all branches so we always emit lints) - rust-lang/rust#149394 (add regression test for guard patterns liveness ICE) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes output of a handful of tests more than the one added in the first commit, but as far as I can tell, all removed suggestions were invalid.
Closes #128381 which is D-invalid-suggestion with two 👍-votes.