[rustdoc] misc search index cleanups #149149

yotamofek · 2025-11-20T15:16:15Z

Bunch of misc cleanups to search index generation (on the rustdoc side). Perf isn't improved unfortunately, but I do think most of these changes are improvements to readability/style.

Probably easier to review commit by commit.

yotamofek · 2025-11-20T15:18:49Z

@bors try @rust-timer queue

…ups, r=<try> [WIP] [rustdoc] misc search index cleanups

yotamofek · 2025-11-20T17:18:56Z

@bors try cancel

rust-bors · 2025-11-20T17:19:00Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/19541816993

yotamofek · 2025-11-20T19:46:13Z

@bors try @rust-timer queue

…ups, r=<try> [WIP] [rustdoc] misc search index cleanups

yotamofek · 2025-11-20T20:19:16Z

This pull request is already queued and waiting for a try build to finish.

Hey @Kobzol , just wanted to make sure.. this is a bug, right?

edit: I mean, seems everything is working fine, but I don't think bors should have posted this comment

Kobzol · 2025-11-20T20:31:27Z

Bors didn't post it, rust-timer did :) It's not a bug, it's an error message. You have already queued this PR before (#149149 (comment)), and then requeued it before the perf. run was finished, so the bot was just letting you know that the second rust-timer queue command was unnecessary. The PR stays queued until the benchmark is done, even if some try builds fail in the meantime.

yotamofek · 2025-11-20T20:37:20Z

Ahhh makes sense, thanks for taking the time to explain!

rust-bors · 2025-11-20T22:03:35Z

☀️ Try build successful (CI)
Build commit: 0c69ac1 (0c69ac16c2e9cd8ab6a183927d44760cd4472397, parent: 7281a3bc4b89a010aed05528d648450feb8b69d3)

rust-timer · 2025-11-21T01:16:46Z

Finished benchmarking commit (0c69ac1): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	56
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	24
All ❌✅ (primary)	-0.1%	[-0.1%, -0.0%]	56

Bootstrap: 472.196s -> 473.864s (0.35%)
Artifact size: 388.85 MiB -> 388.81 MiB (-0.01%)

yotamofek · 2025-11-21T20:38:44Z

@bors try @rust-timer queue

…ups, r=<try> [WIP] [rustdoc] misc search index cleanups

rustbot · 2025-11-25T20:08:27Z

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

yotamofek · 2025-11-25T20:10:15Z

src/librustdoc/html/render/search_index.rs

    pub(crate) fn union(mut self, other: &SerializedSearchIndex) -> SerializedSearchIndex {
        let other_entryid_offset = self.names.len();
-        let mut map_other_pathid_to_self_pathid: Vec<usize> = Vec::new();
+        let mut map_other_pathid_to_self_pathid = Vec::with_capacity(other.path_data.len());


note to self: this is wrong, revert

Ping me once done then? 😉

…g default elements one by one

Also, use `Vec::resize` instead of individual `push`es

… take `&mut Vec`

rustbot · 2025-11-26T10:25:10Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

GuillaumeGomez · 2025-11-26T11:00:18Z

It is much nicer indeed, thanks! r=me once CI pass

yotamofek · 2025-11-26T11:49:03Z

@bors r=GuillaumeGomez rollup

bors · 2025-11-26T11:49:06Z

📌 Commit 2a34631 has been approved by GuillaumeGomez

It is now in the queue for this repository.

Rollup of 12 pull requests Successful merges: - #147936 (Offload intrinsic) - #148358 (Fix some issues around `rustc_public`) - #148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors) - #148751 (Build gnullvm toolchains on Windows natively) - #148951 (rustc_target: aarch64: Remove deprecated FEAT_TME) - #149149 ([rustdoc] misc search index cleanups) - #149173 (Use rust rather than LLVM target features in the target spec) - #149307 (Deny const auto traits) - #149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target) - #149317 (Handle inline asm in has_ffi_unwind_calls) - #149326 (Remove unused `Clone` derive on `DelayedLint`) - #149341 (Add `Copy` to some AST enums.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #149149 - yotamofek:wip/rustdoc/search_index/misc-cleanups, r=GuillaumeGomez [rustdoc] misc search index cleanups Bunch of misc cleanups to search index generation (on the rustdoc side). Perf isn't improved unfortunately, but I do think most of these changes are improvements to readability/style. Probably easier to review commit by commit.

Rollup of 12 pull requests Successful merges: - rust-lang/rust#147936 (Offload intrinsic) - rust-lang/rust#148358 (Fix some issues around `rustc_public`) - rust-lang/rust#148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors) - rust-lang/rust#148751 (Build gnullvm toolchains on Windows natively) - rust-lang/rust#148951 (rustc_target: aarch64: Remove deprecated FEAT_TME) - rust-lang/rust#149149 ([rustdoc] misc search index cleanups) - rust-lang/rust#149173 (Use rust rather than LLVM target features in the target spec) - rust-lang/rust#149307 (Deny const auto traits) - rust-lang/rust#149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target) - rust-lang/rust#149317 (Handle inline asm in has_ffi_unwind_calls) - rust-lang/rust#149326 (Remove unused `Clone` derive on `DelayedLint`) - rust-lang/rust#149341 (Add `Copy` to some AST enums.) r? `@ghost` `@rustbot` modify labels: rollup

…/misc-cleanups, r=GuillaumeGomez [rustdoc] misc search index cleanups Bunch of misc cleanups to search index generation (on the rustdoc side). Perf isn't improved unfortunately, but I do think most of these changes are improvements to readability/style. Probably easier to review commit by commit.

Rollup of 12 pull requests Successful merges: - rust-lang#147936 (Offload intrinsic) - rust-lang#148358 (Fix some issues around `rustc_public`) - rust-lang#148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors) - rust-lang#148751 (Build gnullvm toolchains on Windows natively) - rust-lang#148951 (rustc_target: aarch64: Remove deprecated FEAT_TME) - rust-lang#149149 ([rustdoc] misc search index cleanups) - rust-lang#149173 (Use rust rather than LLVM target features in the target spec) - rust-lang#149307 (Deny const auto traits) - rust-lang#149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target) - rust-lang#149317 (Handle inline asm in has_ffi_unwind_calls) - rust-lang#149326 (Remove unused `Clone` derive on `DelayedLint`) - rust-lang#149341 (Add `Copy` to some AST enums.) r? `@ghost` `@rustbot` modify labels: rollup