resolve: Partially convert ambiguous_glob_imports lint into a hard error

[petrochenkov]

I'm tired of this logic interfering with any attempts to fix or refactor glob imports.

The lint was implemented 2.3 years ago, and made deny-by-default and report-in-dependencies 4 months ago.

The removal is a bit over-eager because of one piece that wasn't implemented correctly (#113099 (comment)), but I want to look at the crater results.

Part of #114095.

[rustbot]

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

[rustbot]

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[petrochenkov]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: 446cb60 (446cb600aa4837dd6c513f14fa0d25a909b177d7, parent: e22dab387f6b4f6a87dfc54ac2f6013dddb41e68)

[petrochenkov]

@craterbot check

[craterbot]

👌 Experiment pr-149195 created and queued.
🤖 Automatically detected try build 446cb60
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-149195 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-149195 is completed!
📊 2676 regressed and 6 fixed (741888 total)
📊 2000 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149195/retry-regressed-list.txt ↩

[nnethercote]

@petrochenkov: seems like a lot of regressions :( Should I review this?

[petrochenkov]

@petrochenkov: seems like a lot of regressions :( Should I review this?

Not yet.
@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[petrochenkov]

The largest part of the regressions are from openssl-0.10.*, it's a known issue that is addressed by #147984.
So this is blocked by #147984 now.
@rustbot blocked

[yaahc]

Correct me if I'm wrong on this one

@rustbot author

[rust-bors]

☀️ Try build successful (CI)
Build commit: 1473190 (14731909456ca628a194900c35659dfdcb359e77, parent: bad50269f8eb0fda214f0478c3afb2c6fbb427fd)

[petrochenkov]

@craterbot run mode=check-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-149195/retry-regressed-list.txt

[craterbot]

👌 Experiment pr-149195-1 created and queued.
🤖 Automatically detected try build 1473190
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-149195-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-149195-1 is completed!
📊 571 regressed and 0 fixed (4523 total)
📊 187 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149195-1/retry-regressed-list.txt ↩

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[petrochenkov]

@bors try

[rust-log-analyzer]

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [rustdoc] tests/rustdoc/glob-shadowing.rs stdout ----
------python3 stdout------------------------------

------python3 stderr------------------------------
2: count check failed
 Expected 6 occurrences but found 7
 //@ count - '//dt' 6
3: !has check failed
 `XPATH PATTERN` unexpectedly matched
 //@ !has - '//dd' 'sub1::describe'
6: !has check failed
 `XPATH PATTERN` unexpectedly matched
 //@ !has - '//dd' 'sub1::describe2'

Encountered 3 errors

------------------------------------------

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/rustdoc/glob-shadowing" "/checkout/tests/rustdoc/glob-shadowing.rs"
stdout: none
--- stderr -------------------------------
2: count check failed
 Expected 6 occurrences but found 7
 //@ count - '//dt' 6
3: !has check failed
 `XPATH PATTERN` unexpectedly matched
 //@ !has - '//dd' 'sub1::describe'
6: !has check failed
 `XPATH PATTERN` unexpectedly matched
 //@ !has - '//dd' 'sub1::describe2'

Encountered 3 errors
------------------------------------------

---- [rustdoc] tests/rustdoc/glob-shadowing.rs stdout end ----

[rust-bors]

☀️ Try build successful (CI)
Build commit: 9cbe924 (9cbe924c1a7ad92a8d63366fe967735898f13b4d, parent: 3391c0133661be933c3ef24edf1867d71b9f206b)

[petrochenkov]

@craterbot run mode=check-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-149195-1/retry-regressed-list.txt

[craterbot]

👌 Experiment pr-149195-2 created and queued.
🤖 Automatically detected try build 9cbe924
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[petrochenkov]

@craterbot p=11
All the small runs will complete in a few hours and won't need to wait for a few days until the long beta runs complete.

[craterbot]

📝 Configuration of the pr-149195-2 experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-149195-2 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-149195-2 is completed!
📊 466 regressed and 0 fixed (758 total)
📊 36 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149195-2/retry-regressed-list.txt ↩