Reexport num_cpus in std::os. Closes #14707#14938
Reexport num_cpus in std::os. Closes #14707#14938japaric wants to merge 1 commit intorust-lang:masterfrom
num_cpus in std::os. Closes #14707#14938Conversation
|
Perhaps the I also don't think that |
I thought about doing this in the first place, but a reexport seemed more conservative than a move. If it's ok to move the function, I can try that in another PR.
I probably worded that bad,
But I couldn't the desired outcome: Only EDIT: Adding |
|
Let's move |
@alexcrichton done |
Add signature help for tuple patterns and expressions ~~These are somewhat wonky since their signature changes as you type depending on context but they help out nevertheless.~~ should be less wonky now with added parser and lowering recoveries
r? @ghost changelog: none
I'm not too confident about my approach regarding the handling of the docs, so here goes my train of thought:
The first commit does the reexport. But the side effect is that two
num_cpusentries appear in the docs:std::os::num_cpusandstd::rt::num_cpus, but we only need the former one.The second commit deals with the duplicated entry. Is my first time using
rustdoc, but I expected that a#[doc(hidden)]attribute on thepub use self::util::num_cpuswould remove the duplicated entry - this didn't work and this seems like a bug to me (or it could be my inexperience withrustdoc). The only way I found to remove the duplicated entry was to make theutilmodule public (this may not be acceptable), in addition to the#[doc(hidden)]attribute.The third commit makes sure that other docs are kept intact (i.e. that the
std::rt::utilmodule doesn't appear in the docs).cc @brson who requested the reexport, and @alexcrichton, who has been working on rustdoc lately.