Rollup of 10 pull requests #149941
Merged
Rollup of 10 pull requests #149941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all.
This logic is cargo-specific anyway, so there is no need for it to be a generally-available helper method.
The `INLINE_ALWAYS_MISMATCHING_TARGET_FEATURES` lint was missing from this causing it to be an unknown lint when attempting to allow it.
…let ... else return`
…toyo Update `rustc_codegen_gcc` rotate operation document ## Description This PR resolves a TODO comment in the `rustc_codegen_gcc` backend by documenting that the rotate operations (`rotate_left` and `rotate_right`) already implement the optimized branchless algorithm from comment. The existing implementation already uses the optimal branchless rotation pattern: - For left rotation: `(x << n) | (x >> (-n & (width-1)))` - For right rotation: `(x >> n) | (x << (-n & (width-1)))` This pattern avoids branches and generates efficient machine code across different platforms, which was the goal mentioned in the original TODO. ## Changes - Removed the TODO comment that suggested implementing the algorithm from https://blog.regehr.org/archives/1063
Use `let...else` instead of `match foo { ... _ => return };` and `if let ... else return`
…49038, r=estebank Add proper suggestion for associated function with unknown field Fixes rust-lang#149038 The first commit is changing the old suggestion to verbose, the second commit is a new added suggestion. r? ``@estebank``
…legation, r=petrochenkov Inherit attributes in delegation This PR adds support for inheriting attributes of the original function of the delegation and is a part of rust-lang#118212, for now we inherit only #[must_use] attribute, but we can add other attributes to inherit. The list of processed attributes can be found [here](https://github.com/aerooneqq/public-docs/blob/master/rust/delegation/processed_attributes.md). r? ``@petrochenkov``
…r=petrochenkov Fix: Prevent macro-expanded extern crates from shadowing extern arguments prevents an ICE by fixing a logic bug in `build_reduced_graph.rs`. the bug caused the compiler to correctly detect and report a shadowing error for a macro-expanded `extern crate` but then continue processing the invalid item, corrupting the resolver's internal state (`extern_prelude`) and leading to a crash in later resolution passes the fix adds an early return after the shadowing error is reported to ensure the invalid item is not added to the resolution graph. Fixes rust-lang#149821
…sync, r=eholk Weak for Arc pointer is marked as DynSend/DynSync `std::sync::Weak` (weak pointer for Arc) added to DynSend and DynSync (looks like it was missed to add there when implemented).
…=jdonszelmann Remove unused code in `cfg_old` r? ```@jdonszelmann``` Fixes one of the todos from rust-lang#149865
bootstrap: Don't pass an unused `--color` to compiletest - Follow-up to rust-lang#149850 --- This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all. A follow-up commit also inlines `force_coloring_in_ci` into its only remaining caller, and updates its comment.
…petrochenkov Add a sanity check in case of any duplicate nodes A simple check in case compiler tries to encode a dep node twice like in rust-lang#141540. Also if we'd try to mark a red node as green as it may then create a bad `DepNodeIndex` like in rust-lang#148295. If it prevents rust-lang#141540 from emitting a faulty `dep-graph.bin` file via panic then it means you will be able to temporarily fix it by simply restarting cargo or rust-analyzer without cleaning up incremental cache.
… r=davidtwco `declare_lint_pass` for `INLINE_ALWAYS_MISMATCHING_TARGET_FEATURES` The `INLINE_ALWAYS_MISMATCHING_TARGET_FEATURES` lint was missing from this causing it to be an unknown lint when attempting to allow it. r? ``@davidtwco``
rustbot
added
A-attributes
rustbot
added
A-query-system
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: dc47a69ed9 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing dc47a69 (parent) -> ce63e5d (this PR) Test differencesShow 1060 test diffsStage 0
Stage 1
Stage 2
(and 166 additional test diffs) Additionally, 794 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard ce63e5d9ea20f15a70c6fdc4d4de7aee352fd965 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Dec 13, 2025
Collaborator
|
Finished benchmarking commit (ce63e5d): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -3.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 475.622s -> 476.217s (0.13%) |
This was referenced Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_codegen_gccrotate operation document #145278 (Updaterustc_codegen_gccrotate operation document)let...elseinstead ofmatch foo { ... _ => return };andif let ... else return#148837 (Uselet...elseinstead ofmatch foo { ... _ => return };andif let ... else return)cfg_old#149903 (Remove unused code incfg_old)--colorto compiletest #149911 (bootstrap: Don't pass an unused--colorto compiletest)declare_lint_passforINLINE_ALWAYS_MISMATCHING_TARGET_FEATURES#149924 (declare_lint_passforINLINE_ALWAYS_MISMATCHING_TARGET_FEATURES)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup