Fix ICE (#149980) for invalid EII in statement position #150160
+264
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
fix-149980
branch
from
fa2968f to
3f802ea
Compare
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
fix-149980
branch
from
3f802ea to
cff246f
Compare
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
fix-149980
branch
from
cff246f to
7b23803
Compare
jdonszelmann
force-pushed
the
fix-149980
branch
from
7b23803 to
c316c05
Compare
Contributor
Author
|
r? kivooeo (Would you like to review this one? You also interacted with the other PRs :3) |
Member
|
I was casually working on #149981 like last 7 hours or so (I lost time track at some point) But we need to discuss somewhere the behaviour you think is best here, because it will be offtopic here, would you mind me quick dm you in zulip? I still have like 30 minutes before sleep cuz it's 3:30 am to me As for this, would it be fine if I check this tomorrow? I'll need some time to get into the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #150159
Fixes #149980