Skip to content

Conversation

@dianqk
Copy link
Member

@dianqk dianqk commented Dec 20, 2025

Fixes #149813.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2025

⚠️ Warning ⚠️

@dianqk
Copy link
Member Author

dianqk commented Dec 20, 2025

cc @mati865 (rust-lang/llvm-project#193)

@cuviper
Copy link
Member

cuviper commented Dec 20, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Dec 20, 2025

📌 Commit 361888f has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2025
@bors
Copy link
Collaborator

bors commented Dec 21, 2025

⌛ Testing commit 361888f with merge a6525d5...

@bors
Copy link
Collaborator

bors commented Dec 21, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing a6525d5 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 21, 2025
@bors bors merged commit a6525d5 into rust-lang:main Dec 21, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 21, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d3f16d2 (parent) -> a6525d5 (this PR)

Test differences

Show 5 test diffs

Stage 2

  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) (J0)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a6525d5264da34f51ad48c178281d3c6323dbfcf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2702.6s -> 3740.5s (+38.4%)
  2. pr-check-1: 1684.2s -> 2241.8s (+33.1%)
  3. x86_64-gnu-tools: 3195.4s -> 4213.2s (+31.9%)
  4. pr-check-2: 2307.3s -> 3007.4s (+30.3%)
  5. x86_64-gnu-gcc: 3060.5s -> 3954.0s (+29.2%)
  6. x86_64-gnu: 7398.8s -> 9362.2s (+26.5%)
  7. tidy: 166.1s -> 134.4s (-19.1%)
  8. x86_64-gnu-miri: 4571.2s -> 5419.5s (+18.6%)
  9. x86_64-gnu-distcheck: 7688.7s -> 8980.5s (+16.8%)
  10. armhf-gnu: 5139.3s -> 5972.1s (+16.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a6525d5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.9%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.3% [5.3%, 5.3%] 1
Improvements ✅
(primary)
-2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)
-1.0% [-1.0%, -1.0%] 1
All ❌✅ (primary) -2.9% [-2.9%, -2.9%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 481.777s -> 479.783s (-0.41%)
Artifact size: 390.59 MiB -> 390.59 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[x86_64-pc-windows-gnullvm] Can't build proc macros using rust-lld, failing with undefined symbol: _DllMainCRTStartup

5 participants