Skip to content

Rollup of 2 pull requests#150381

Merged
bors merged 4 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-c7pqytw
Dec 25, 2025
Merged

Rollup of 2 pull requests#150381
bors merged 4 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-c7pqytw

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Dec 25, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Mark-Simulacrum and others added 4 commits December 21, 2025 20:14
@Mark-Simulacrum
Write file with channel to S3
bdc8894 
This will let rustup-toolchain-install-master gain support for
installing stable artifacts, which is currently only possible when
explicitly overriding the channel. That in turn will unblock letting
Crater kick off a beta run as soon as both a new beta and a new stable
artifact are ready, rather than waiting until the actual release.
@cuiweixie
refactor: simplify code
b22b089
@JonathanBrouwer
Rollup merge of rust-lang#149964 - Mark-Simulacrum:ci-channel, r=Kobzol
2a9bc18 
Write file with channel to S3

This will let rustup-toolchain-install-master gain support for installing stable artifacts, which is currently only possible when explicitly overriding the channel. That in turn will unblock letting Crater kick off a beta run as soon as both a new beta and a new stable artifact are ready, rather than waiting until the actual release.
@JonathanBrouwer
Rollup merge of rust-lang#150365 - cuiweixie:first_pr, r=JonathanBrou…
d37f008 
…wer,Kivooeo

refactor: simplify code
@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 25, 2025
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Dec 25, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Dec 25, 2025

📌 Commit d37f008 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2025
@bors
Copy link
Collaborator

bors commented Dec 25, 2025

⌛ Testing commit d37f008 with merge fabece9...

@cuiweixie
Copy link
Contributor

cuiweixie commented Dec 25, 2025

@JonathanBrouwer May I ask why still pending, from my perspective, it should be done now.

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Dec 25, 2025

@cuiweixie The big CI which runs on everything that is merged into main usually takes 3-4 hours, so it should be done soon :)
It actually tests a crazy large amount of things on a crazy large amount of platforms, so have some patience

@bors
Copy link
Collaborator

bors commented Dec 25, 2025

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing fabece9 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 25, 2025
@bors bors merged commit fabece9 into rust-lang:main Dec 25, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 25, 2025
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 25, 2025

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#149964 Write file with channel to S3 cb5b3490fe6ab234431eef9767d54e28a513b0d4 (link)
#150365 refactor: simplify code e58aeaf42d4706d6718b9d5b5872090551ca07d9 (link)

previous master: 1bf12c32a0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 1bf12c3 (parent) -> fabece9 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard fabece9e9491d0a3c3655dba488881968b7c5f7a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 10960.4s -> 9076.6s (-17.2%)
  2. dist-aarch64-apple: 5873.3s -> 6839.2s (+16.4%)
  3. aarch64-gnu-llvm-20-1: 3423.4s -> 3882.5s (+13.4%)
  4. x86_64-gnu-miri: 4362.1s -> 4796.5s (+10.0%)
  5. x86_64-msvc-ext1: 7183.9s -> 7897.9s (+9.9%)
  6. pr-check-1: 1647.0s -> 1806.7s (+9.7%)
  7. aarch64-msvc-2: 5971.7s -> 6507.6s (+9.0%)
  8. x86_64-mingw-1: 9163.7s -> 9775.1s (+6.7%)
  9. x86_64-gnu-tools: 3291.1s -> 3507.7s (+6.6%)
  10. dist-i686-mingw: 8857.9s -> 9430.7s (+6.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Dec 26, 2025

Finished benchmarking commit (fabece9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.2% [4.2%, 4.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.4% [-3.4%, -3.4%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary 4.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.6% [3.7%, 5.5%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 482.343s -> 482.281s (-0.01%)
Artifact size: 392.46 MiB -> 392.44 MiB (-0.01%)

@github-actions github-actions bot mentioned this pull request Jan 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

6 participants

@JonathanBrouwer @bors @cuiweixie @rust-timer @rustbot @Mark-Simulacrum