Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions compiler/rustc_parse/src/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2203,6 +2203,15 @@ pub(crate) struct DefaultNotFollowedByItem {
pub span: Span,
}

#[derive(Diagnostic)]
#[diag("`final` is not followed by an item")]
#[note("only associated functions in traits may be prefixed by `final`")]
pub(crate) struct FinalNotFollowedByItem {
#[primary_span]
#[label("the `final` qualifier")]
pub span: Span,
}

#[derive(Diagnostic)]
pub(crate) enum MissingKeywordForItemDefinition {
#[diag("missing `enum` for enum definition")]
Expand Down
2 changes: 2 additions & 0 deletions compiler/rustc_parse/src/parser/item.rs
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,8 @@ impl<'a> Parser<'a> {

if let Defaultness::Default(span) = def {
this.dcx().emit_err(errors::DefaultNotFollowedByItem { span });
} else if let Defaultness::Final(span) = def {
this.dcx().emit_err(errors::FinalNotFollowedByItem { span });
}

if !attrs_allowed {
Expand Down
7 changes: 7 additions & 0 deletions tests/ui/traits/final/bad-positions.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#![feature(final_associated_functions)]

fn main() {
final; //~ ERROR `final` is not followed by an item
final 1 + 1; //~ ERROR `final` is not followed by an item
final { println!("text"); }; //~ ERROR `final` is not followed by an item
}
26 changes: 26 additions & 0 deletions tests/ui/traits/final/bad-positions.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
error: `final` is not followed by an item
--> $DIR/bad-positions.rs:4:5
|
LL | final;
| ^^^^^ the `final` qualifier
|
= note: only associated functions in traits may be prefixed by `final`

error: `final` is not followed by an item
--> $DIR/bad-positions.rs:5:5
|
LL | final 1 + 1;
| ^^^^^ the `final` qualifier
|
= note: only associated functions in traits may be prefixed by `final`

error: `final` is not followed by an item
--> $DIR/bad-positions.rs:6:5
|
LL | final { println!("text"); };
| ^^^^^ the `final` qualifier
|
= note: only associated functions in traits may be prefixed by `final`

error: aborting due to 3 previous errors

Loading