Add missing safety doc for CString::from_vec_unchecked and async_drop_in_place#153384
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 13, 2026
Merged
Add missing safety doc for CString::from_vec_unchecked and async_drop_in_place#153384rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @joboet rustbot has assigned @joboet. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
asder8215
reviewed
Mar 5, 2026
asder8215
reviewed
Mar 5, 2026
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
rustbot
added
has-merge-commits
rustbot
removed
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Member
|
It looks fine, but I'm not familiar with async drop things, so In any case, you'll need to squash commits. |
Collaborator
|
|
hxuhack
force-pushed
the
main
branch
3 times, most recently
from
78c6f70 to
6de39ba
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
requested changes
Mar 13, 2026
rustbot
removed
the
S-waiting-on-review
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
…uwer Rollup of 7 pull requests Successful merges: - #153650 (Streamline active job collection.) - #153707 (Remove `CycleErrorHandling`.) - #153384 (Add missing safety doc for CString::from_vec_unchecked and async_drop_in_place) - #153752 (fix(delegation): Filter Out Module Segments in Generic Args Inheritance) - #153797 (Compiletest: Fix compare-output-by-lines directive) - #153810 (compiletest: Use PYTHONPATH for lldb too, not only gdb) - #153820 (Rename `opt_span_diag_lint` into `opt_span_lint` and remove `emit_diag_lint`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing safety documentation for two unsafe APIs:
CString::from_vec_unchecked– # Safety: the caller must ensurevcontains no NUL bytes in its contents.async_drop_in_place– # Safety: see [ptr::drop_in_place] for safety requirements.