Skip to content

Remove TyCtxt::node_span_lint method#153621

Merged
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
GuillaumeGomez:migrate-diag
Mar 10, 2026
Merged

Remove TyCtxt::node_span_lint method#153621
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
GuillaumeGomez:migrate-diag

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Mar 9, 2026

Part of #153099.

One less obstacle before we can remove lint_level function. :)

r? @JonathanBrouwer

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2026

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 9, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2026

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 9, 2026
Open
3 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Mar 9, 2026

Forgot to remove intra-doc links. Fixed. :)

JonathanBrouwer
JonathanBrouwer requested changes Mar 9, 2026
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2026
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Mar 9, 2026

Updated!

JonathanBrouwer
JonathanBrouwer approved these changes Mar 9, 2026
View reviewed changes
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with green ci

View changes since this review

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Mar 9, 2026

@bors r=JonathanBrouwer rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 9, 2026

📌 Commit 4d7624e has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2026
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 10, 2026
@bors
Auto merge of #153642 - matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
2254b92 
Rollup of 4 pull requests

Successful merges:

 - #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
 - #153325 (tests/ui/cfg: add annotations for reference rules)
 - #153621 (Remove `TyCtxt::node_span_lint` method)
 - #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 10, 2026
@bors
Auto merge of #153621 - GuillaumeGomez:migrate-diag, r=JonathanBrouwer
b996427 
Remove `TyCtxt::node_span_lint` method

Part of #153099.

One less obstacle before we can remove `lint_level` function. :)

r? @JonathanBrouwer
@rust-bors rust-bors bot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2026
@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 10, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 10, 2026

💔 Test for b996427 failed: CI. Failed job:

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Mar 10, 2026

@bors retry

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2026
rust-bors bot pushed a commit that referenced this pull request Mar 10, 2026
@bors
Auto merge of #153642 - matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
5c216d1 
Rollup of 4 pull requests

Successful merges:

 - #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
 - #153325 (tests/ui/cfg: add annotations for reference rules)
 - #153621 (Remove `TyCtxt::node_span_lint` method)
 - #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
rust-bors bot pushed a commit that referenced this pull request Mar 10, 2026
@bors
Auto merge of #153642 - matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
0c68443 
Rollup of 4 pull requests

Successful merges:

 - #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
 - #153325 (tests/ui/cfg: add annotations for reference rules)
 - #153621 (Remove `TyCtxt::node_span_lint` method)
 - #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Mar 10, 2026

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
/dev/sda15      105M  6.2M   99M   6% /boot/efi
tmpfs           1.6G   12K  1.6G   1% /run/user/1001
================================================================================

Sufficient disk space available (95909328KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Mar 10, 2026

@bors retry

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 10, 2026

❗ You can only retry pull requests that are approved and have a previously failed auto build.

@rust-bors rust-bors bot merged commit 531dafd into rust-lang:main Mar 10, 2026
11 of 12 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 10, 2026
rust-timer added a commit that referenced this pull request Mar 10, 2026
@rust-timer
Unrolled build for #153621
8bcd519 
Rollup merge of #153621 - GuillaumeGomez:migrate-diag, r=JonathanBrouwer

Remove `TyCtxt::node_span_lint` method

Part of #153099.

One less obstacle before we can remove `lint_level` function. :)

r? @JonathanBrouwer
@GuillaumeGomez GuillaumeGomez deleted the migrate-diag branch March 10, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer approved these changes

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @rustbot @rust-log-analyzer @JonathanBrouwer