Make par_slice consistent with single-threaded execution#153768
Make par_slice consistent with single-threaded execution#153768rust-bors[bot] merged 1 commit intorust-lang:mainfrom
par_slice consistent with single-threaded execution#153768Conversation
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Make `par_slice` consistent with single-threaded execution
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (92a974f): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 480.488s -> 481.482s (0.21%) |
|
@rustbot ready |
This comment has been minimized.
This comment has been minimized.
|
@Zoxc I think it makes sense but do you have any thoughts on this? Just wanna make sure it doesn't hurt your intention. |
580788b to
8e38aa0
Compare
This comment has been minimized.
This comment has been minimized.
|
@JohnTitor No, the change is fine. |
This comment has been minimized.
This comment has been minimized.
8e38aa0 to
50c564e
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing e52f547 (parent) -> 7218b7f (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 7218b7fa17e8ef5e99525ae25e6e82224c27039d --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (7218b7f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.5%, secondary -0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 483.272s -> 499.005s (3.26%) |
#152375 removed this consistency by switching from order preserving join to scope, which does not preserve order as stated in
par_fnsas well. This also makespar_slicebehavior consistent withpar_fns.