Skip to content

Couple of driver interface improvements#153778

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
bjorn3:driver_cleanups
Mar 18, 2026
Merged

Couple of driver interface improvements#153778
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
bjorn3:driver_cleanups

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Mar 12, 2026 •
edited
Loading

  • Pass Session to make_codegen_backend callback. This simplifies some code in miri.
  • Move env/file_depinfo from ParseSess to Session. There is no reason it has to be in ParseSess rather than Session.
  • Rename hash_untracked_state to track_state to indicate that it isn't just used for hashing state, but also for adding env vars and files to be tracked through the dep info file.

@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2026

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2026
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2026

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 16 candidates

bjorn3
bjorn3 commented Mar 12, 2026
View reviewed changes
compiler/rustc_interface/src/interface.rs
@@ -337,11 +336,14 @@ pub struct Config {
/// This is a callback from the driver that is called when [`ParseSess`] is created.
pub psess_created: Option<Box<dyn FnOnce(&mut ParseSess) + Send>>,
Copy link
Member Author

@bjorn3 bjorn3 Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only remaining users of this callback I'm aware of use it to set a different diagnostic emitter. bjorn3/rust@b219d18 replaces this with a diagnostic emitter builder. I don't have strong opinion on whether to do this or not.

bjorn3
bjorn3 commented Mar 12, 2026
View reviewed changes
compiler/rustc_interface/src/interface.rs
/// runs the incremental cache will be cleared.
///
/// The hashing functionality has no known user. FIXME should this be removed?
pub track_state: Option<Box<dyn FnOnce(&Session, &mut StableHasher) + Send>>,
Copy link
Member Author

@bjorn3 bjorn3 Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the hashing functionality be removed?

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Mar 18, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 18, 2026

📌 Commit 2199d07 has been approved by TaKO8Ki

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2026
@Zalathar Zalathar mentioned this pull request Mar 18, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 18, 2026
@bors
Auto merge of #154032 - Zalathar:rollup-Aejl3zc, r=Zalathar
a3903b1 
Rollup of 3 pull requests

Successful merges:

 - #153998 (Move query-stack-frame spans into `QueryStackFrame`)
 - #153778 (Couple of driver interface improvements)
 - #154026 (Remove unused types `UnusedGenericParams` and `FiniteBitSet`)
@rust-bors rust-bors bot merged commit 44c8729 into rust-lang:main Mar 18, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 18, 2026
@bjorn3 bjorn3 deleted the driver_cleanups branch March 18, 2026 09:29
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Mar 19, 2026
@bors
Auto merge of #154032 - Zalathar:rollup-Aejl3zc, r=Zalathar
8bc8e81 
Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#153998 (Move query-stack-frame spans into `QueryStackFrame`)
 - rust-lang/rust#153778 (Couple of driver interface improvements)
 - rust-lang/rust#154026 (Remove unused types `UnusedGenericParams` and `FiniteBitSet`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TaKO8Ki TaKO8Ki TaKO8Ki approved these changes

Assignees

@TaKO8Ki TaKO8Ki

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bjorn3 @rustbot @rust-log-analyzer @TaKO8Ki