Conversation
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Also, remove the comments describing what the test is doing if the test is simple enough. However, keep an issue link and add a new line between your comment and the test. Here's an example of what the test could look like: #152732. |
This comment has been minimized.
This comment has been minimized.
| @@ -1,3 +1,5 @@ | |||
| // https://github.com/rust-lang/rust/issues/4265 | |||
There was a problem hiding this comment.
This should not be moved to ui/traits, there are no traits involved at all.
|
@rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
f0c2376 to
24c516f
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@rustbot ready |
What do you mean by that |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
I was referring to the @rustbot bless command. |
|
there is no CI-bless command or any way to do so... I think the best way you can do is run |
|
Oh, I see. You can't run the compile test because you can't build the library. In that case, I could try pushing these changes directly into your branch. I'm not sure how feasible this is for GSoC, but we could give you access to our cloud computing if you were chosen for the project. |
Reorganize 11 tests in tests/ui/issues to appropriate subdirectories
This PR reorganizes tests in tests/ui/issues folder following the workflow suggested in the comment on #149411
Workflow:
All tests pass tidy locally using
python x.py test tidy