suggest valid features when target feature is invalid#153966
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 17, 2026
Merged
suggest valid features when target feature is invalid#153966rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
rust-bors
bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Mar 17, 2026
…names, r=mati865 suggest valid features when target feature is invalid I run into this quite frequently, where I remember some part of a feature name but not the exact name. Now this emits suggestions like ``` error: the feature named `+avx512` is not valid for this target --> $DIR/invalid-attribute.rs:127:18 | LL | #[target_feature(enable = "+avx512")] | ^^^^^^^^^^^^^^^^^^ `+avx512` is not valid for this target | = help: valid names are: `avx512f`, `avx2`, `avx512bw`, `avx512cd`, and `avx512dq` and 74 more ```
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
Rollup of 5 pull requests Successful merges: - #146013 (Add `From` impls for wrapper types) - #153966 (suggest valid features when target feature is invalid) - #153372 (Fix LegacyKeyValueFormat report from docker build: x86_64-gnu) - #153738 (Don't look for non-type-level assoc consts when checking trait object types) - #153921 (Suppress self-referential associated type constraint suggestion)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Mar 17, 2026
…names, r=mati865 suggest valid features when target feature is invalid I run into this quite frequently, where I remember some part of a feature name but not the exact name. Now this emits suggestions like ``` error: the feature named `+avx512` is not valid for this target --> $DIR/invalid-attribute.rs:127:18 | LL | #[target_feature(enable = "+avx512")] | ^^^^^^^^^^^^^^^^^^ `+avx512` is not valid for this target | = help: valid names are: `avx512f`, `avx2`, `avx512bw`, `avx512cd`, and `avx512dq` and 74 more ```
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
Rollup of 5 pull requests Successful merges: - #153966 (suggest valid features when target feature is invalid) - #153372 (Fix LegacyKeyValueFormat report from docker build: x86_64-gnu) - #153738 (Don't look for non-type-level assoc consts when checking trait object types) - #153907 (Remove redundant fields from `QueryStackFrame`) - #153921 (Suppress self-referential associated type constraint suggestion)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run into this quite frequently, where I remember some part of a feature name but not the exact name. Now this emits suggestions like